Skip to content

Commit 6a62a34

Browse files
dannikayXiaochu Liu
authored andcommitted
reuse custom cluster arguments isnteead
1 parent 8804fc2 commit 6a62a34

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

src/xpk/commands/cluster.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -953,7 +953,7 @@ def update_coredns_if_necessary(args) -> int:
953953
0 if successful (CoreDNS was already present or successfully deployed),
954954
and 1 otherwise.
955955
"""
956-
if args.enable_cloud_dns:
956+
if '--cluster-dns=clouddns' in args.custom_cluster_arguments:
957957
xpk_print('Skipping CoreDNS deployment since Cloud DNS is enabled.')
958958
return 0
959959
elif coredns_deployment_exists(args, namespace='kube-system'):
@@ -1134,9 +1134,6 @@ def run_gke_cluster_create_command(
11341134
if args.enable_workload_identity or args.enable_gcsfuse_csi_driver:
11351135
command += f' --workload-pool={args.project}.svc.id.goog'
11361136

1137-
if args.enable_cloud_dns:
1138-
command += f' --cluster-dns=clouddns'
1139-
11401137
addons = []
11411138
if args.enable_gcsfuse_csi_driver:
11421139
addons.append('GcsFuseCsiDriver')

src/xpk/parser/cluster.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -715,11 +715,6 @@ def add_shared_cluster_create_optional_arguments(parser: ArgumentParser):
715715
action='store_true',
716716
help='Enable Workload Identity Federation on the cluster and node-pools.',
717717
)
718-
parser.add_argument(
719-
'--enable-cloud-dns',
720-
action='store_true',
721-
help='Enable Cloud DNS on the cluster and node-pools.',
722-
)
723718
add_driver_arguments(parser)
724719

725720

0 commit comments

Comments
 (0)