fixing bugs

Author: Tushar3099

README.md

@@ -24,10 +24,14 @@ RCE is a Remote Code Executor, as the name suggests Is a Docker-based sandbox en
 # build docker image
 docker-compose build
 
+# create volume
+docker volume create my_vol
+
 # run server in development mode
 docker-compose up server
 ```
 
+`
 This will build the required docker image and run the server in a docker container which will be listening at http://localhost:3000.
 
 ### For development and adding features
@@ -44,7 +48,8 @@ Runs the application is development mode. Should not be used in production
 npm run dev
 ```
 
-This is for development of the application.
+This is for
+development of the application.
 
 #### Run in _production_ mode:
 

server/api/services/code.service.js

@@ -2,18 +2,32 @@ import fs from "fs";
 import path from "path";
 import util from "util";
 import { execFile, spawn, exec } from "child_process";
+import ValidationService from "./validation.service";
 const ROOT_DIR = `${process.cwd()}`;
 const SOURCE_DIR = path.join(ROOT_DIR, "executor");
 const TARGET_DIR = `/app/codes`;
 const IMAGE_NAME = "executor:1.0";
 const VOL_NAME = `my_vol`;
+// const VOL_NAME = SOURCE_DIR;
 
 class CodeService {
   async execute(code, input, lang, id) {
     try {
       !input ? (input = "") : null;
+
       //validating code
       // await this.validateCode(code, input, lang, id);
+      const { isValid, message } = await ValidationService.execute(
+        code,
+        input,
+        lang,
+        id
+      );
+      if (!isValid) {
+        throw {
+          message,
+        };
+      }
 
       //writing the code,input  files
       const { file, inputFile } = await this.writeFile(code, lang, input, id);
@@ -44,20 +58,6 @@ class CodeService {
     }
   }
 
-  async validateCode(code, input, lang, id) {
-    switch (lang) {
-      case "javascript": {
-        let words = ["require(", "exports.", "module.exports"];
-        // prevent imports
-        var valid = !words.some((el) => {
-          return code.includes(el);
-        });
-        if (!valid) throw { message: "You have unacceptable libs imported" };
-      }
-    }
-    // throw { message: "You librabry is not accepted : " + lib };
-  }
-
   async writeFile(code, lang, input, id) {
     let fileName = `${id}code`;
     switch (lang) {
@@ -115,7 +115,7 @@ class CodeService {
 
     const runCode = `docker exec ${containerName} sh -c "${command}"`;
 
-    const runContainer = `docker run -it -d --name ${containerName} --mount source=${VOL_NAME},target=${TARGET_DIR} ${IMAGE_NAME}`;
+    const runContainer = `docker run -it -d --name ${containerName} -v ${VOL_NAME}:${TARGET_DIR} ${IMAGE_NAME}`;
 
     return { runCode, runContainer };
   }

server/api/services/validation.service.js

@@ -0,0 +1,48 @@
+class ValidationService {
+  async execute(code, input, lang, id) {
+    switch (lang) {
+      case "javascript": {
+        let words = ["require(", "exports.", "module.exports"];
+        // prevent imports
+        var valid = !words.some((el) => {
+          return code.includes(el);
+        });
+        return {
+          isValid: valid,
+          message: "You have unacceptable libs imported",
+        };
+      }
+      case "python": {
+        let reg1 = RegExp(
+          /\bimport\W+(?:\w+\W+){0,}(?:os|subprocess|importlib)\b/g
+        );
+        words = ["open("];
+
+        if (code.match(reg1)) {
+          return {
+            isValid: false,
+            message: "You have unacceptable libs imported",
+          };
+        } else if (
+          words.every((el) => code.toLowerCase().includes(el.toLowerCase()))
+        ) {
+          return {
+            isValid: false,
+            message: "You have unacceptable libs imported",
+          };
+        }
+        return {
+          isValid: true,
+        };
+      }
+      default: {
+        return {
+          isValid: false,
+          message: "Please select a valid language",
+        };
+      }
+    }
+  }
+}
+
+export default new ValidationService();