gql.tada turbo Maximum call stack size exceeded

[arjunyel]

Describe the bug

I've been using the turbo command for a while now. Today I added some new queries and now I am getting a Maximum call stack size exceeded error and I am not even sure how to begin debugging it. I was going to ask in discord but the link https://urql.dev/discord is broken. Thank you for the help!

 ⚠ Unexpected Error 
Could not build cache
┗ RangeError: Maximum call stack size exceeded
      at getNameOfSymbolAsWritten (/test/node_modules/typescript/lib/typescript.js:58431:36)
      at createExpressionFromSymbolChain (/test/node_modules/typescript/lib/typescript.js:55959:27)
      at symbolToExpression (/test/node_modules/typescript/lib/typescript.js:55952:14)
      at symbolToNode (/test/node_modules/typescript/lib/typescript.js:54160:14)
      at /test/node_modules/typescript/lib/typescript.js:54068:144
      at withContext2 (/test/node_modules/typescript/lib/typescript.js:54191:29)
      at symbolToNode (/test/node_modules/typescript/lib/typescript.js:54068:80)
      at symbolToStringWorker (/test/node_modules/typescript/lib/typescript.js:53958:22)
      at usingSingleLineStringWriter (/test/node_modules/typescript/lib/typescript.js:16324:5)
      at symbolToString (/test/node_modules/typescript/lib/typescript.js:53956:62)

Reproduction

No response

gql.tada version

"gql.tada": "^1.8.2",
"typescript": "5.5.4"

Validations

• I can confirm that this is a bug report, and not a feature request, RFC, question, or discussion, for which GitHub Discussions should be used
• Read the docs.
• Follow our Code of Conduct

[JoviDeCroock]

The discord link works just fine for me 😅 from what I can tell we are stuck in one of these checker calls mind putting a console log there and printing the document in question? You can do that with callExpression.getFullText()

[JoviDeCroock]

That's odd, we see 12 logs of a document and 12 logs of a documentType 😅 Depending on where you logged that it should be a different amount, was trying to lock down where this happens. That being said, I would love a reproduction instead then as remote debugging like this won't work

The only thing I can think of is you have a circular fragment

[kitten]

Closing due to lack of reproduction.

[raphael-yapla]

@JoviDeCroock @kitten I'm facing the same issue after updating from an older version of gql.tada. I'm not using the turbo command but it breaks very similarly on the check command.

Here's a reproduction repo with the problem:

https://github.com/raphael-yapla/gql-tada-vue-issue/tree/nested-fragment-composition

I couldn't pinpoint exactly which package/subpackage version breaks the command but you can have a look at this lockfile commit to get a better idea: raphael-yapla/gql-tada-vue-issue@2883b60

This bug is completely breaking gql.tada for us so it would be really appreciated if you give it another look, let me know if I can do anything else to help with this!

[arjunyel]

@JoviDeCroock @kitten I'm facing the same issue after updating from an older version of gql.tada. I'm not using the turbo command but it breaks very similarly on the check command.

Here's a reproduction repo with the problem:

https://github.com/raphael-yapla/gql-tada-vue-issue/tree/nested-fragment-composition

I couldn't pinpoint exactly which package/subpackage version breaks the command but you can have a look at this lockfile commit to get a better idea: raphael-yapla/gql-tada-vue-issue@2883b60

This bug is completely breaking gql.tada for us so it would be really appreciated if you give it another look, let me know if I can do anything else to help with this!

@raphael-yapla hi friend, thank you so much for making a reproduction! I think you should make a new issue since this one is closed so they might miss your comment

[kitten]

@raphael-yapla: Cheers! I'll take a look tomorrow. Shouldn't take too long with the reproduction ❤️

@arjunyel: Nah, no worries. Notifications are ongoing without mentions/re-opening being needed, since all participants are subscribed, unless they unsubscribe.

Just to narrow this down. Were you using Vue or Svelte as well by any chance?

[arjunyel]

@raphael-yapla: Cheers! I'll take a look tomorrow. Shouldn't take too long with the reproduction ❤️

@arjunyel: Nah, no worries. Notifications are ongoing without mentions/re-opening being needed, since all participants are subscribed, unless they unsubscribe.

Just to narrow this down. Were you using Vue or Svelte as well by any chance?

I'm using tada in both a Remix and Nodejs project in an NX monorepo. Thank you for taking a look friend!

[kitten]

@raphael-yapla: Your issue is quite straightforward. We didn't have a log message for this, but your version of @vue/language-core contained breaking changes that caused us to not transpile .vue files. This PR fixes this and also attempts to add a basic check for the future that'll let us know if this happens again (which would make this a third(?) time of a breaking change in a patch for that package): #353

@arjunyel: If you're not using Vue, your issue is likely unrelated. I've got a WIP change to handle this without a crash (0no-co/GraphQLSP#347) but fundamentally, I don't know what's causing this issue in your case. My suspicion is that an import/definition of a fragment cannot be resolved, but without a reproduction (assuming since you're using Remix, you're not using Vue), I can't tell you for sure what's causing this.

Hence, I'll tag this issue with "needs more info" again, since only one of the two reports here will be resolved by the linked PR (#353)